fix: Update server capacity calculation#6163
Merged
AyshaHakeem merged 11 commits intofrappe:developfrom Apr 24, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6163 +/- ##
===========================================
- Coverage 55.78% 49.06% -6.73%
===========================================
Files 931 910 -21
Lines 76751 75838 -913
Branches 525 353 -172
===========================================
- Hits 42814 37208 -5606
- Misses 33909 38606 +4697
+ Partials 28 24 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AyshaHakeem
force-pushed
the
fix-site-or-bench-placement
branch
from
a281b5e to
7082113
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the heuristic used by Press to pick the least-loaded public primary server per cluster for use_for_new_sites / use_for_new_benches, normalizing site CPU load by server vCPU capacity.
Changes:
- Updates the scoring definition to use
(sum(site_plan.cpu_time_per_day for non-archived/suspended sites)) / server_vcpu. - Adds a QueryBuilder query to fetch server vCPU capacity (via Server Plan) with a fallback to 1.
- Ensures every server in
server_namesreceives a score entry (including servers with no eligible sites).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AyshaHakeem
force-pushed
the
fix-site-or-bench-placement
branch
from
7082113 to
27bd19c
Compare
AyshaHakeem
requested review from
balamurali27,
ssiyad and
tanmoysrt
as code owners
AyshaHakeem
force-pushed
the
fix-site-or-bench-placement
branch
2 times, most recently
from
5eb41b0 to
e98a603
Compare
- Update heurisitic to set use_for_new_site & and use_for_new_benches flags in server record: - Weight sum of sum of site plan cpu_time_per_day across all sites against server vcpu capacity
- Consider active, public primary servers for each cluster - Fetch available memory and available vCPU for all servers in bulk from Prometheus - Mark the server with most memory for new benches and the one with most vCPU for new sites
…nch creation: - These flags are maintained by refresh_new_bench_and_site_server_pool background job. - This validation prevents site/bench creation failures for newly created clusters before the job runs.
- Prefer use_for_new_sites and use_for_new_benches via ordering instead of filtering to avoid selection failures
AyshaHakeem
force-pushed
the
fix-site-or-bench-placement
branch
from
a11590d to
891673f
Compare
Collaborator
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update logic for use_for_new_benches and use_for_new_sites server flags are refreshed
Misc: